Move from default COUNT_CODEPOINTS unit to COUNT_GRAPHEMES
#1617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The length of strings calculated in the UI via JS and in the backend would differ in a lot of cases. Moving to `COUNT_GRAPHEMES` should fix that. I changed the length assertion in cases where the user is presented with a textarea.
|
If I should commit the controller I wrote to test this I can :) |
melroy89
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length of strings calculated in the UI via JS and in the backend would differ in a lot of cases. Moving to
COUNT_GRAPHEMESshould fix that. I changed the length assertion in cases where the user is presented with a textarea.Fixes #1541