Remove code for using a background image on boards #5409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Board and BoardView code that allowed using a large background image for the board instead of the usual hex tileset. This was unused (although we did have one such background image in the distribution) and probably completely unknown. It is also rather inflexible and it is hard to see how to integrate it into other systems. Therefore it seems better to relieve Board and BoardView of the code parts.
The deleted board file was probably suitable for the deleted image file but the board file did not use the necessary keyword and using a standard tileset it doesn't look like a well-made map.