Make BoardView tooltip modular #5432
Conversation
…p-separation2 # Conflicts: # megamek/src/megamek/client/ui/swing/boardview/BoardViewPanel.java # megamek/src/megamek/client/ui/swing/boardview/IBoardView.java
…ip, color settings changes
| /** | ||
| * The currently selected weapon on the currently selected entity (if any), -1 otherwise | ||
| */ | ||
| private int selectedWeapon = -1; |
There was a problem hiding this comment.
Can -1 be made a constant?
| * | ||
| * @see BoardView#setTooltipProvider(BoardViewTooltipProvider) | ||
| */ | ||
| public interface BoardViewTooltipProvider { |
There was a problem hiding this comment.
It seems like we normally use "I" as the leading character in an Interface name, although I'm not sure if that's by convention or a rule.
There was a problem hiding this comment.
I wouldnt say that its a rule, rather the opposite. I try not using the I* when I can avoid it. I only use it when the fitting interface name is taken by the present class name and I want to avoid having 140 files changed because of a name change. I know its happened rather often in my PRs tho. Changing the name of Game would be a real multi-hit wonder. There'll be a time when I do that tho :)
| if (GUIP.getShowMapHexPopup() && (mhex != null)) { | ||
| StringBuffer sbTerrain = new StringBuffer(); | ||
| appendTerrainTooltip(sbTerrain, mhex, GUIP); | ||
| String sTrerain = sbTerrain.toString(); |
There was a problem hiding this comment.
Typo? 'sTrerain' -> 'sTerrain'?
There was a problem hiding this comment.
yes indeed. Not my typo :) I corrected it
This PR
While I believe that the tooltips are working, I can't imagine that there aren't going to be any side effects, especially with moving selectedEntity and *weapon out of the BoardView
The board editor tooltip:
