Fixes #5650 Weapon unselect after torso twist. #5711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5711 +/- ##
============================================
- Coverage 29.34% 29.33% -0.01%
- Complexity 13868 13872 +4
============================================
Files 2466 2467 +1
Lines 263322 263338 +16
Branches 47174 47166 -8
============================================
- Hits 77264 77254 -10
- Misses 182170 182194 +24
- Partials 3888 3890 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert a change to
UnitDisplay::displayEntity()that was causing weapon selection after a torso twist to become unselected along with other potential entity state changes in various phases to become undone.Fixes #5650