Enable Visual range and Move Envelope to toggle individually #5726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5726 +/- ##
============================================
- Coverage 29.29% 29.09% -0.20%
- Complexity 13877 13879 +2
============================================
Files 2468 2505 +37
Lines 264115 265930 +1815
Branches 47316 47556 +240
============================================
+ Hits 77368 77378 +10
- Misses 182845 184653 +1808
+ Partials 3902 3899 -3 ☔ View full report in Codecov by Sentry. |
kuronekochomusuke
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a side-effect that was introduced in PR #5712 to resolve #5700.
The side-effect is: When in the movement phase with Visual and Sensor range enabled, when the selected unit has no movement path, or Escape, or Backspace were pressed, the Visual and Sensor Range sprites would be removed.
The correct operation is that the Visual and Sensor Range must be able to be toggled on and off independently of the Movement Envelope and Movement Modifier sprites.