Fix for long-standing NPE issue with Aerospace path generation on airless ground maps #5771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, let's start with 1/4th of the stack size; the speedup seems worth it, and if we run into any issues we can roll back to 1/2. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5771 +/- ##
============================================
- Coverage 29.07% 29.07% -0.01%
+ Complexity 13910 13909 -1
============================================
Files 2507 2507
Lines 266309 266312 +3
Branches 47598 47599 +1
============================================
- Hits 77422 77421 -1
- Misses 184968 184971 +3
- Partials 3919 3920 +1 ☔ View full report in Codecov by Sentry. |
|
You are correct on the maximum path length.
TW, page 92. I assume the "1 MP" is supposed to be "1 Thrust". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current ground map pathing code for Aerospace units is fairly simplistic, and in the situation where turns are free (because ASFs on airless / trace atmosphere maps use Spheroid movement) will enter an infinite regress while trying to determine all possible valid moves.
The fix is to restrict Aerospace pathing to 1/2 default Java stack size; there's really no need to even go this far for every possible turn-move-turn combo, because (IIRC) the maximum hover path length on the ground map is 8 hexes, but I wanted to be circumspect.
In my testing I found that reducing the max pathing depth to 256 moves was actually quite fast, so we may wish to consider this in the future.
Note that Princess is actually not very good with Spheroid movement on ground maps but at least this will prevent the StackOverflow error.
Testing:
Close #3595