fix: properly handles exception for weapon data serialization #6906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6906 +/- ##
============================================
- Coverage 30.20% 30.19% -0.01%
+ Complexity 15713 15711 -2
============================================
Files 2884 2884
Lines 283119 283157 +38
Branches 49302 49308 +6
============================================
- Hits 85510 85507 -3
- Misses 192000 192038 +38
- Partials 5609 5612 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| return map; | ||
| } catch (Exception e) { | ||
| logger.error(e, "Error while trying to serialize Weapon {} data for {}", weapon, entity); |
Check warning
Code scanning / CodeQL
Unused format argument Warning
There was a problem hiding this comment.
This is a false positive
|
|
||
| return map; | ||
| } catch (Exception e) { | ||
| logger.error(e, "Error while trying to serialize Weapon {} data for {}", weapon, entity); |
Check warning
Code scanning / CodeQL
Unused format argument Warning
There was a problem hiding this comment.
This is a false positive
rjhancock
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does?
Handles exceptions gracefully.
Improvements to do
Remove the code duplication, to be done at a later date.