TacOps BAP rule offboard checks #6112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6112 +/- ##
=========================================
Coverage 29.07% 29.07%
- Complexity 13970 13972 +2
=========================================
Files 2601 2601
Lines 267448 267447 -1
Branches 47758 47758
=========================================
+ Hits 77764 77767 +3
+ Misses 185788 185782 -6
- Partials 3896 3898 +2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usual, guard against offboard and null positions for TacOps BAP rule (I'm making the assumption that BAP range will never include offboard units)
should fix #6083