Fix 6032: Filter out Aakar font from Java font family names #6318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 28.95% 28.97% +0.02%
- Complexity 14032 14073 +41
============================================
Files 2672 2672
Lines 269306 269379 +73
Branches 47939 47953 +14
============================================
+ Hits 77971 78049 +78
+ Misses 187433 187361 -72
- Partials 3902 3969 +67 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We determined that Aakar causes graphical glitches and artefacts when used in MegaMek.
This font has known issues at least in Ubuntu 18 and later (q.v.) but is not available / installed by default in other OSes, so removing it should be a non-issue.
I've confirmed that this change also makes the font unavailable for MML and MHQ as well, although it should be retained as an MML export option for completeness.
Testing:
Close #6032