fix: stops jumping hovers from reaching orbit #7031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constantly increasing its height
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7031 +/- ##
============================================
+ Coverage 30.22% 30.40% +0.18%
- Complexity 15889 16167 +278
============================================
Files 2895 2895
Lines 284655 284659 +4
Branches 49529 49531 +2
============================================
+ Hits 86036 86558 +522
+ Misses 192992 192129 -863
- Partials 5627 5972 +345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nice! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes jumping elevation issues for units in WiGE and HOVER modes and addresses an out-of-bounds exception in bridge collapse handling. Key changes include:
- Adding and updating several unit tests in JumpTest.java and MovePathTest.java to validate jump behavior.
- Adjusting elevation calculations in MoveStep.java to correctly handle WiGE and HOVER movement modes.
- Updating comments and safeguards in TWGameManager.java to prevent OOB exceptions and ensuring clarity in load handling across floors.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| megamek/unittests/megamek/common/movepath/JumpTest.java | Added comprehensive tests for jump paths across multiple terrains. |
| megamek/unittests/megamek/common/MovePathTest.java | Minor import reordering to follow test conventions. |
| megamek/src/megamek/server/totalwarfare/TWGameManager.java | Updated comments related to collapse load safeguards and added import. |
| megamek/src/megamek/common/MoveStep.java | Modified elevation logic using a switch statement for movement modes. |
5a65786 to
9dd1e6c
Compare
9dd1e6c to
acd5f76
Compare
Sleet01
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does?
Fixes the way elevation is set for units with MovementMode WiGE and HOVER during jumping, and fixes an OOB exception on collapsing bridges.
In a unit test I managed to reproduce the bug where hovers take flight after jumping over a building.
Related issues: