Fix: CodeQL Useless comparison test. #7125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDEA CodeQL Updates
Contributor
There was a problem hiding this comment.
Pull Request Overview
General cleanup of the TipOfTheDay rendering code to remove redundancies and modernize Java syntax.
- Consolidated AWT imports and removed a redundant cast in tip indexing
- Replaced classic switch statements with switch expressions
- Extracted repeated drawing logic into a new helper method
Comments suppressed due to low confidence (2)
megamek/src/megamek/common/util/TipOfTheDay.java:263
- You're using
AffineTransformwithout an import forjava.awt.geom.AffineTransform. Either add the import or fully qualify the class to avoid compilation errors.
AffineTransform gradientTx = AffineTransform.getTranslateInstance(bgRectX, bgRectBottomY);
megamek/src/megamek/common/util/TipOfTheDay.java:387
- Referencing and assigning to
labelDrawXinside a switch expression initializer may not compile, since the target variable isn't definitely assigned in that scope. Consider using a new local variable and yielding its value.
labelDrawX = startX + (currentAvailableTextWidth - labelWidth) / 2; // Center label
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7125 +/- ##
============================================
- Coverage 30.77% 30.75% -0.02%
+ Complexity 17004 16987 -17
============================================
Files 2941 2941
Lines 287710 287680 -30
Branches 50224 50223 -1
============================================
- Hits 88535 88477 -58
- Misses 192659 192729 +70
+ Partials 6516 6474 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Scoppio
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General cleanup of issues found with CodeQL tools and IDEA Analysis.