fix: stop npe whe a board is missing to generate board for acar #7167
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix a NullPointerException that occurs when a board is missing by updating the logic for iterating through the boards array.
- Replaces a traditional for-loop with an iterator-based loop over the boards vector
- Introduces a null and empty check to skip invalid board names
| while (boardsIterator.hasNext()) { | ||
| String name = boardsIterator.next(); | ||
|
|
||
| if (name == null || name.isEmpty()) { |
There was a problem hiding this comment.
Skipping the increment of 'i' when a board name is null or empty might lead to misalignment between the iterator and the sheetBoards array indexes. Consider incrementing 'i' even when skipping an empty name or adjust the loop logic to ensure the sheetBoards array is populated correctly.
There was a problem hiding this comment.
Thats literally what I want to do here... 🤷🏼
There was a problem hiding this comment.
Copilot’s been struggling with these, it hit me with a bunch of false positives over a for loop where I used “i” the other day.
There was a problem hiding this comment.
Why not switch to a foreach instead of the iterator?
There was a problem hiding this comment.
Because I need the index.
|
Related issue MegaMek/mekhq#7121 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7167 +/- ##
============================================
+ Coverage 30.64% 30.65% +0.01%
- Complexity 17128 17150 +22
============================================
Files 2968 2968
Lines 289621 289627 +6
Branches 50488 50489 +1
============================================
+ Hits 88754 88797 +43
+ Misses 194267 194219 -48
- Partials 6600 6611 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix: stop npe whe a board is missing to generate board for acar