Fix: Battle Armor unit does not die with all members dead #7169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7169 +/- ##
============================================
- Coverage 30.67% 30.64% -0.03%
+ Complexity 17127 17121 -6
============================================
Files 2968 2968
Lines 289606 289614 +8
Branches 50483 50488 +5
============================================
- Hits 88829 88750 -79
- Misses 194130 194263 +133
+ Partials 6647 6601 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SJuliez
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the
damageEntity()refactoring process, I skipped over a call todestroyEntity()in the new Battle Armor-specific function.Originally it was gated behind a check for
!engineExplosionand looked like it only applied to Meks and Vehicles, so I removed it.This caused MegaMek to hang when attempting to destroy BA units because the rollForHitLocation() method would infinitely loop, trying to find the next location to destroy even after all troopers were killed.
Let this be a lesson: Always Destroy Battle Armor!
Patch also adds the ability to load recent nightly saves into the dev code of the same version (but not to or from releases).
Testing:
Close #7159
Close #7160