Issue: correct issues with the unittooltip not displaying correctly in the report #7222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kuronekochomusuke
commented
Jun 7, 2025
- correct issues with the unittooltip not displaying correctly in the report
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7222 +/- ##
============================================
- Coverage 30.75% 30.73% -0.02%
+ Complexity 17581 17546 -35
============================================
Files 2974 2974
Lines 290337 290346 +9
Branches 50611 50599 -12
============================================
- Hits 89285 89239 -46
- Misses 194338 194409 +71
+ Partials 6714 6698 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses formatting issues for unit tooltips within the report view by removing legacy <pre> tag injections in the server report generator and gating sensor‐only tooltips on the report flag in the client.
- Remove hard‐coded closing/opening
<pre>wrappers around the status report - Always generate the report section for unit tooltips at a fixed position
- Skip sensor‐only tooltips when rendering in report mode on the client
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| megamek/src/megamek/server/totalwarfare/TWGameManager.java | Stripped out <pre> tag inserts and adjusted report creation sequence |
| megamek/src/megamek/client/ui/clientGUI/tooltip/UnitToolTip.java | Added !report check to prevent sensor‐only tooltips from appearing in reports |
Comments suppressed due to low confidence (2)
megamek/src/megamek/server/totalwarfare/TWGameManager.java:1857
- Here
rstill refers to the previous Report instance instead of a new one that would re-enable<pre>formatting. This will add the wrong object and drop necessary<pre>tags, breaking report layout. Consider reinstating a new Report with<pre>before this call.
reports.add(r);
megamek/src/megamek/client/ui/clientGUI/tooltip/UnitToolTip.java:131
- [nitpick] This new
reportflag check changes tooltip logic; there may not be existing tests covering both branches. Add a unit test to verify sensor-only tooltips are correctly skipped whenreportis true.
if ((!report) && (EntityVisibilityUtils.onlyDetectedBySensors(localPlayer, entity))) {
| boolean inGameValue, boolean showBV, boolean showSensors, boolean showSeenBy, boolean report) { | ||
| // Tooltip info for a sensor blip | ||
| if (EntityVisibilityUtils.onlyDetectedBySensors(localPlayer, entity)) { | ||
| if ((!report) && (EntityVisibilityUtils.onlyDetectedBySensors(localPlayer, entity))) { |
There was a problem hiding this comment.
[nitpick] The extra parentheses around each condition are unnecessary. Simplify to if (!report && EntityVisibilityUtils.onlyDetectedBySensors(localPlayer, entity)) for improved readability.
Suggested change
| if ((!report) && (EntityVisibilityUtils.onlyDetectedBySensors(localPlayer, entity))) { | |
| if (!report && EntityVisibilityUtils.onlyDetectedBySensors(localPlayer, entity)) { |
rjhancock
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.