Name guide argument in hGraph()
#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanxstats
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Thanks @teunbrand for the patch and detailed explanation. I appreciate the effort. I'm merging this and will send a new release of gMCPLite to CRAN this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break gMCPLite. The culprit of the breakage is that we have made the
nameargument of scales the first, see tidyverse/ggplot2#5583.Because
hGraph()passes the legend as an unnamed argument, this gets matched by position to thenameargument in the new version of ggplot2. This PR names the guide argument to prevent it being passed to the wrong argument.To test the code changes with the release candidate, you can install it with the code below:
The release of ggplot2 3.5.0 is scheduled at the end of January / early Februari. The progress can be tracked in tidyverse/ggplot2#5588.