Open
Conversation
Member
Author
|
Should we make armors repairable? |
Litorom
requested changes
Jul 11, 2023
Member
|
You can't include commits from other pull requests in this pull request. I have already told you this... We also can't have both of these. I thought I made it pretty clear that we won't add new items/entities. |
Member
Author
|
This is the better way to implement repairing. We can not implement tool repair without any addition. |
Member
|
Remove the Dark Anvil. |
Member
Author
|
Is it good to have ability to break down tools back to their raw materials and ability to repair armors? |
Member
|
I would like it possible to have repairable armor, but that requires the armor system to be renovated |
# Conflicts: # src/client/java/minicraft/item/FishingRodItem.java # src/client/java/minicraft/item/FurnitureItem.java # src/client/java/minicraft/item/Recipes.java # src/client/java/minicraft/item/ToolItem.java # src/client/java/minicraft/saveload/Load.java # src/client/java/minicraft/screen/Menu.java
# Conflicts: # src/client/java/minicraft/saveload/Load.java # src/client/java/minicraft/util/MyUtils.java
Member
|
This is a good addition to the game, but I still don't see the need for the dark anvil. I see it's still in the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on #534
From #521
This adds a new furniture, Repair Bench, made from early materials; costs raw materials of tools to repair tools; allows repairing more common items, i.e. fishing rod items.