refactor: moving message sendinng handler to new class #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f841d0 to
ddd0560
Compare
|
Kudos, SonarCloud Quality Gate passed! |
paulpach
reviewed
Mar 19, 2021
| void Send<T>(T message, int channelId = Channel.Reliable); | ||
|
|
||
| void Send(ArraySegment<byte> segment, int channelId = Channel.Reliable); | ||
| void Send<T>(INetworkPlayer player, T message, int channelId = Channel.Reliable); |
Contributor
There was a problem hiding this comment.
why does the Send need the player?
BREAKING CHANGE: todo
moving MessageBroker to its own file
ddd0560 to
f4482f0
Compare
Member
Author
|
new version of PR #818 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Moving message handler from NetworkPlayer to MessageBroker.