fix: adding error for generated read writer for abstract class #2191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93f6af7 to
0c7b2ca
Compare
weaver can not initialize class abstract class so cant not create a reader this gives a helpful error telling the server to make a custom reader
0c7b2ca to
d22934f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Sep 21, 2020
# [43.7.0](v43.6.0...v43.7.0) (2020-09-21) ### Bug Fixes * adding error for generated read writer for abstract class ([#2191](https://github.com/MirrorNG/MirrorNG/issues/2191)) ([a9d21ea](a9d21ea)) * adding error when Server/Client is used on abstract methods ([#1978](https://github.com/MirrorNG/MirrorNG/issues/1978)) ([c1410b0](c1410b0)) * adding version define from v17 breaking change ([c6fa49c](c6fa49c)) * auto fill serialize/deserialize for classes ([#2120](https://github.com/MirrorNG/MirrorNG/issues/2120)) ([890ee6b](890ee6b)), closes [#2117](https://github.com/MirrorNG/MirrorNG/issues/2117) [#2117](https://github.com/MirrorNG/MirrorNG/issues/2117) * ClientScene.localplayer is now set to null when it is destroyed ([#2227](https://github.com/MirrorNG/MirrorNG/issues/2227)) ([5edba81](5edba81)) * fixing cloud log not using logger ([#2141](https://github.com/MirrorNG/MirrorNG/issues/2141)) ([a124f3f](a124f3f)) * Fixing IndexChanged hook not being called for NetworkRoomPlayer ([#2242](https://github.com/MirrorNG/MirrorNG/issues/2242)) ([94da8ae](94da8ae)) * fixing NullReferenceException when loading scene ([#2240](https://github.com/MirrorNG/MirrorNG/issues/2240)) ([5eb5ff6](5eb5ff6)) * fixing unity crash on StackOverflowException ([#2146](https://github.com/MirrorNG/MirrorNG/issues/2146)) ([ec54ee6](ec54ee6)) * fixing warning message for client attribute ([#2144](https://github.com/MirrorNG/MirrorNG/issues/2144)) ([ddc6139](ddc6139)) * fixing width and layout group on cloud example ([#2201](https://github.com/MirrorNG/MirrorNG/issues/2201)) ([fc53078](fc53078)) * isServer false in OnDestroy ([#2101](https://github.com/MirrorNG/MirrorNG/issues/2101)) ([d46469a](d46469a)) * making triggers be called right away instead on owner ([#2125](https://github.com/MirrorNG/MirrorNG/issues/2125)) ([7604e65](7604e65)) * Nested messages ([#2148](https://github.com/MirrorNG/MirrorNG/issues/2148)) ([e4a5ce7](e4a5ce7)) * Unity Editor 2019/2020 crashes in Play Mode when resizing Editor for Macbooks with on board graphics cards. Using Metal instead of OpenGL fixes it. See also: https://forum.unity.com/threads/unity-editor-crashes-macos.739535/ ([e2fd195](e2fd195)) * weaver test for abstract methods ([#2166](https://github.com/MirrorNG/MirrorNG/issues/2166)) ([3a276b4](3a276b4)) ### Features * Added Layer Weight to NetworkAnimator ([#2134](https://github.com/MirrorNG/MirrorNG/issues/2134)) ([23b9fb0](23b9fb0)) * Adding Custom Data and Custom Address fields to list server ([#2110](https://github.com/MirrorNG/MirrorNG/issues/2110)) ([e136f48](e136f48)) * adding script to help debug list server ([#2202](https://github.com/MirrorNG/MirrorNG/issues/2202)) ([5701369](5701369)) * allowing lists to automatically be sent in Commands, Rpc, and Messages ([#2151](https://github.com/MirrorNG/MirrorNG/issues/2151)) ([381e5a1](381e5a1)) * making NetworkBehaviour.IsDirty public ([#2208](https://github.com/MirrorNG/MirrorNG/issues/2208)) ([1ade82d](1ade82d)) * Use Server Client attribute outside of NetworkBehaviour ([#2150](https://github.com/MirrorNG/MirrorNG/issues/2150)) ([eec49fa](eec49fa)) ### Performance Improvements * **weaver:** No need to manually load mirror and unity assemblies ([#2261](https://github.com/MirrorNG/MirrorNG/issues/2261)) ([e50ea63](e50ea63)) * adding check for no connections ([#2130](https://github.com/MirrorNG/MirrorNG/issues/2130)) ([150b14a](150b14a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weaver can not initialize class abstract class so cant not create a reader
this gives a helpful error telling the server to make a custom reader
Will merge once tests pass