Improve IR reliability on blinks dev kits with silicone covers #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 4, 2018 23:45
…he sendpulse... ...rathger than using a fixed window.
…ways chared before the begining of the SYNC
…o error check yet. Also alows the blinkstate face values to be full bytes now. Even without error checks, the new more restrictive formating checks seem to eleminate almost all IR errors for blinks with LOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No downsides, just tightens up the edges for this communication path. Effectively eliminates data errors for tiles that have LOS. There are still some places for errors to sneak in when tiles are moved, but those will be addressed with error checking.