Allow to pass variables to create_pipeline #401
Conversation
| 'key' => key, | ||
| 'value' => value | ||
| ) | ||
| end |
There was a problem hiding this comment.
Let variables be a string. We don't need this conversion logic in API wrapper.
NARKOZ
left a comment
There was a problem hiding this comment.
Thanks. I've left a comment. Also CI build for linting needs fixing.
|
Kind reminder @lksv |
|
Any progress here? I've stumbled over the same 'issue' and would love to see this feature merged. :) |
| post( | ||
| "/projects/#{url_encode project}/pipeline", | ||
| query: { ref: ref }, | ||
| body: JSON.dump(normalized_variables) |
There was a problem hiding this comment.
I've played around with this change and noticed that it does not work as expected. The problem is, that the API is missing the name of the parameter (variables=... see https://docs.gitlab.com/ee/api/pipelines.html#create-a-new-pipeline). Furthermore this gem sets the Content-Type header to x-www-form-urlencoded so the server does not understand the json structure which is sent in the body of the request.
The following code fixes these issues:
def create_pipeline(project, ref, variables = {})
# This is necessary, cause the API expects an array with objects (with `key` and `value` keys) <_<
normalized_variables = variables.each_with_object([]) do |(key, value), res|
res.push(key: key, value: value)
end
post(
"/projects/#{url_encode project}/pipeline",
query: { ref: ref },
body: { variables: normalized_variables },
)
end@NARKOZ do you prefer that this MR gets updated, or should I open another MR with this fix?
No description provided.