Add merge_base support #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NARKOZ
requested changes
Aug 17, 2018
Owner
NARKOZ
left a comment
There was a problem hiding this comment.
Thanks. I've left comments regarding the docs.
lib/gitlab/client/repositories.rb
Outdated
| # Gitlab.merge_base(42, ['master', 'feature/branch']) | ||
| # | ||
| # @param [Integer] project The ID of a project. | ||
| # @param [String] refs Array containing 2 commit SHAs, branch names, or tags. |
lib/gitlab/client/repositories.rb
Outdated
| # Gitlab.merge_base(42, ['master', 'feature/branch']) | ||
| # Gitlab.merge_base(42, ['master', 'feature/branch']) | ||
| # | ||
| # @param [Integer] project The ID of a project. |
Owner
There was a problem hiding this comment.
@param [Integer, String] project The ID or URL-encoded path of the project.
Contributor
Author
|
@NARKOZ Thanks for the quick review. Comments addressed. |
NARKOZ
approved these changes
Aug 17, 2018
Owner
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the repositories merge_base API endpoint documented here.
It uses the sample response from the docs for spec/fixtures/merge_base.json.