Missing templates (gitignores, gitlab_ci_ymls, dockerfiles, licenses)… #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and project level templates for the same
connorshea
reviewed
Nov 25, 2018
connorshea
reviewed
Nov 25, 2018
connorshea
reviewed
Nov 25, 2018
NARKOZ
requested changes
Nov 26, 2018
Owner
NARKOZ
left a comment
There was a problem hiding this comment.
Thank you for the PR. I've left a comment.
lib/gitlab/client.rb
Outdated
| include Environments | ||
| include Events | ||
| include GitignoreTemplates | ||
| include GitlabCiYmlTemplates |
Owner
There was a problem hiding this comment.
Can we merge all these modules into one Templates module? Because technically it's one endpoint: /templates. Except ProjectTemplates module - it's methods should go to Projects module.
Collaborator
Author
There was a problem hiding this comment.
Made changes. Need review.
Owner
|
Kind reminder @akkee |
Collaborator
Author
|
@NARKOZ , will update will the requested changes soon. |
2. Moved projects templates to Projects
NARKOZ
approved these changes
Dec 10, 2018
Owner
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and project level templates for the same
Closes #432 and closes #226