Add support to handle 429 responses from a rate limited gitlab instance #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR. Could you add tests for this change? |
Author
|
I'll try. |
Gitlab may respond with a 429 error and a message of 'Retry later'. The response body in this case has content-type 'text/plain'. This change adds support for 429 errors and processes the body of responses with content formated as 'text/plain'. Add tests for the changes to Gitlab:Error:ResponseError.build_error_message
b5b7a5d to
46b65e5
Compare
Author
|
I added two tests to exercise the method I added. I sorry they aren't very good, I don't know how to create a httparty::response for testing. |
NARKOZ
approved these changes
Jan 30, 2019
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitlab may respond with a 429 error and a message of 'Retry later'. The
response body in this case has content-type 'text/plain'. This change
adds support for 429 errors and processes the body of responses with
content formated as 'text/plain'.
Should fix issue #458.