Add group-issues API (redux)#465
Merged
NARKOZ merged 4 commits intoNARKOZ:masterfrom Feb 8, 2019
SeanSith:get-group-issues
Merged
Add group-issues API (redux)#465NARKOZ merged 4 commits intoNARKOZ:masterfrom SeanSith:get-group-issues
NARKOZ merged 4 commits intoNARKOZ:masterfrom
SeanSith:get-group-issues
Conversation
NARKOZ
requested changes
Feb 1, 2019
lib/gitlab/client/issues.rb
Outdated
| # @return [Array<Gitlab::ObjectifiedHash>] | ||
| def group_issues(group=nil, options={}) | ||
| get("/groups/#{group}/issues", query: options) | ||
| end |
Owner
There was a problem hiding this comment.
This should go into lib/gitlab/client/groups.rb
spec/gitlab/client/issues_spec.rb
Outdated
| end | ||
|
|
||
| describe '.issue' do | ||
| describe ".group_issues" do |
Owner
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
lib/gitlab/client/issues.rb
Outdated
| # @param [Integer, String] group_id The ID or name of a group. | ||
| # @param [Hash] options A customizable set of options. | ||
| # @return [Array<Gitlab::ObjectifiedHash>] | ||
| def group_issues(group=nil, options={}) |
Owner
There was a problem hiding this comment.
Surrounding spaces missing in default value assignments.
NARKOZ
requested changes
Feb 8, 2019
lib/gitlab/client/groups.rb
Outdated
| # @param [Integer, String] group_id The ID or name of a group. | ||
| # @param [Hash] options A customizable set of options. | ||
| # @return [Array<Gitlab::ObjectifiedHash>] | ||
| def group_issues(group = nil, options = {}) |
Owner
There was a problem hiding this comment.
First argument (group) is required therefore shouldn't have a default value.
NARKOZ
approved these changes
Feb 8, 2019
Owner
|
Thank you! |
haghighi
pushed a commit
to haghighi/gitlab
that referenced
this pull request
Jun 22, 2019
* Add get-group-issues * Fix failing shell_spec test for completions * Moved group_issues to Gitlab::Client::Groups - Per @NARKOZ's comments on NARKOZ#465, moved `group_issues` into lib/gitlab/client/groups.rb - Following with the above, moved the test to groups_spec.rb, as well. - Corrected linting failures noted by @NARKOZ and rspec. * group_issues: Removed default for 'group' parameter
onshi
pushed a commit
to onshi/gitlab
that referenced
this pull request
Apr 30, 2020
* Add get-group-issues * Fix failing shell_spec test for completions * Moved group_issues to Gitlab::Client::Groups - Per @NARKOZ's comments on NARKOZ#465, moved `group_issues` into lib/gitlab/client/groups.rb - Following with the above, moved the test to groups_spec.rb, as well. - Corrected linting failures noted by @NARKOZ and rspec. * group_issues: Removed default for 'group' parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on the feedback in #343 fixed the failing test.