Forward missing messages on Error to the parsed response #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error response may contain useful additional context, and this allows users to access that context on the exception class. For example, the cherry-pick API now includes an `error_code` field to indicate why the cherry-pick failed, which can now be accessed via `Error#error_code`.
NARKOZ
approved these changes
Nov 26, 2019
Owner
|
👍 |
NARKOZ
added a commit
that referenced
this pull request
Dec 19, 2019
Revert "Merge pull request #530 from rspeicher/rs-error-method-missing"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error response may contain useful additional context, and this allows
users to access that context on the exception class.
For example, the cherry-pick API now includes an
error_codefield toindicate why the cherry-pick failed, which can now be accessed via
Error#error_code.