Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Merge pull request #530 from rspeicher/rs-error-method-missing" #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NARKOZ merged 1 commit into from
Dec 19, 2019
Merged

Revert "Merge pull request #530 from rspeicher/rs-error-method-missing" #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions lib/gitlab/error.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,18 +78,6 @@ def handle_message(message)
message
end
end

def method_missing(method, *args, &block)
if @response.parsed_response.key?(method)
@response.parsed_response[method]
else
super
end
end

def respond_to_missing?(method, include_private = false)
super || @response.parsed_response.key?(method, include_private)
end
end

# Raised when API endpoint returns the HTTP status code 400.
Expand Down
16 changes: 0 additions & 16 deletions spec/gitlab/error_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,4 @@
response_double = double('response', body: 'Retry later', to_s: 'Retry text', parsed_response: { message: 'Retry hash' }, code: 429, options: {}, headers: headers, request: @request_double)
expect(described_class.new(response_double).send(:build_error_message)).to match(/Retry hash/)
end

it 'passes missing messages to the parsed response' do
response_hash = { message: 'Failed to cherry-pick', error_code: 'empty' }
response_double = double(
'response',
body: JSON.dump(response_hash),
parsed_response: response_hash,
code: 400,
headers: { 'content-type' => 'application/json' },
request: @request_double
)

error = described_class.new(response_double)

expect(error.error_code).to eq(response_hash[:error_code])
end
end