Ruby 3 support #615
Merged
Ruby 3 support #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More specific for method_missing: Keyword arguments are separated from other argument https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
… or special symbols.
NARKOZ
requested changes
May 15, 2021
Owner
NARKOZ
left a comment
There was a problem hiding this comment.
Thank you for the PR! I'll merge it after the comments get addressed.
asedge
reviewed
May 16, 2021
NARKOZ
approved these changes
May 17, 2021
Owner
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem (wrong number of arguments) passing optional params to the variables endpoint using Ruby 3.
The problem related to this change: Keyword arguments are separated from other arguments (https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/).