Add merge request level rule endpoints #617
Merged
+206
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NARKOZ
approved these changes
Jun 30, 2021
Owner
|
Thank you ❤️ |
|
@NARKOZ As more and more GitLab instances are being upgraded to 14.0, is there a timeline for a release that includes these changes? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that after Gitlab 13.12 MR /approvers endpoint was removed.
(cant find endpoint in 13.12 https://docs.gitlab.com/13.12/ee/api/merge_request_approvals.html but was available in 13.10 - https://docs.gitlab.com/13.10/ee/api/merge_request_approvals.html#change-allowed-approvers-for-merge-request)
Added 3 new endpoints:
Have not tested them e2e yet, gonna try in my project- OKMaybe its worth adding @deprecated for other MR /approvers endpoints also- added