Implement group hooks crud #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.gitlab.com/ee/api/groups.html#delete-group-hook The API returns status and empty body. The library converts the empty body into an empty Gitlab::ObjectifiedHash. In test, the stub converts an empty body to False. Decided to represent all of this by making the fixture accuractly represent the response body and have the test method call out the discrepancy.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@dipolesource could you reopen this pr? |
NARKOZ
approved these changes
Jun 13, 2024
Owner
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the CRUD API for Group Hooks https://docs.gitlab.com/ee/api/groups.html#hooks
While implementing we noticed that the CLI spec exits early, thus when rake spec is run with a random seed you do not run the full test suite. We tried setting a CI env but that didn't change the behavior. Rather than jam up this PR with extra behavior, we implemented here without updating the test suite. Happy to chat with you about submitting another PR that updates contributor doc, test harness behavior, or tests to help the issue described here.