Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ruby 3.4 - require 'stringio' for Gitlab::CLI::Helpers #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NARKOZ merged 2 commits into from
Jun 12, 2025
Merged

ruby 3.4 - require 'stringio' for Gitlab::CLI::Helpers #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c442db2
Adding Ruby 3.4 to CI
stevequinlan Feb 22, 2025
c3f07bb
require stringio in Gitlab::CLI::Helpers to support ruby 3-4
stevequinlan Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
- 3.1
- 3.2
- 3.3
- 3.4
name: Ruby ${{ matrix.ruby }} test
steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions lib/gitlab/cli_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
require 'yaml'
require 'json'
require 'base64'
require 'stringio'
Copy link
Contributor Author

@stevequinlan stevequinlan Feb 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To recreate, install ruby 3.4 and make a call to the gitlab create_merge_request command. It results in:

/Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli_helpers.rb:143:in 'block (3 levels) in Gitlab::CLI::Helpers#record_table': uninitialized constant Gitlab::CLI::Helpers::StringIO (NameError)

            when StringIO
                 ^^^^^^^^
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli_helpers.rb:139:in 'Array#each'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli_helpers.rb:139:in 'block (2 levels) in Gitlab::CLI::Helpers#record_table'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli_helpers.rb:136:in 'Array#each'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli_helpers.rb:136:in 'Enumerable#each_with_index'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli_helpers.rb:136:in 'block in Gitlab::CLI::Helpers#record_table'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/terminal-table-4.0.0/lib/terminal-table/table.rb:355:in 'Terminal::Table#yield_or_eval'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/terminal-table-4.0.0/lib/terminal-table/table.rb:21:in 'Terminal::Table#initialize'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/terminal-table-4.0.0/lib/terminal-table/table_helper.rb:5:in 'Class#new'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/terminal-table-4.0.0/lib/terminal-table/table_helper.rb:5:in 'Terminal::Table::TableHelper#table'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli_helpers.rb:132:in 'Gitlab::CLI::Helpers#record_table'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli_helpers.rb:100:in 'Gitlab::CLI::Helpers#output_table'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli.rb:86:in 'Gitlab::CLI.render_output'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli.rb:76:in 'Gitlab::CLI.run'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/lib/gitlab/cli.rb:24:in 'Gitlab::CLI.start'
	from /Users/user/.rvm/gems/ruby-3.4.0/gems/gitlab-5.1.0/exe/gitlab:11:in '<top (required)>'
	from /Users/user/.rvm/gems/ruby-3.4.0/bin/gitlab:25:in 'Kernel#load'
	from /Users/user/.rvm/gems/ruby-3.4.0/bin/gitlab:25:in '<main>'
	from /Users/user/.rvm/gems/ruby-3.4.0/bin/ruby_executable_hooks:22:in 'Kernel#eval'
	from /Users/user/.rvm/gems/ruby-3.4.0/bin/ruby_executable_hooks:22:in '<main>'

No issue under ruby 3.3


class Gitlab::CLI
# Defines methods related to CLI output and formatting.
Expand Down