Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@logicminds
Copy link
Contributor

  • the user can now create commits through the gem by posting
    one or more file changes (file content). This can be extremely
    useful in situations where you don't want to distribute ssh keys,
    and use api tokens instead with CI systems.

@logicminds logicminds force-pushed the commit branch 5 times, most recently from d5d2b15 to fc32ef8 Compare March 17, 2017 21:32
@logicminds logicminds changed the title WIP: Adds ability to create commits Adds ability to create commits Mar 17, 2017
@logicminds
Copy link
Contributor Author

@NARKOZ ping

@asedge
Copy link
Collaborator

asedge commented Mar 23, 2017

What's with all the indentation changes in commits_spec.rb?

@logicminds
Copy link
Contributor Author

Rubymine auto format.

@logicminds
Copy link
Contributor Author

Are the indentation changes holding this PR up? Do you need me to change this. Really need this feature added. @asedge

@logicminds
Copy link
Contributor Author

The spacing differences are because the code is considered a continuation line which my editor spaces 4 over instead of 2.

@asedge
Copy link
Collaborator

asedge commented Mar 27, 2017

Yeah, please clean up those changes unrelated to the PR. Thanks!

   * the user can now create commits through the gem by posting
     one or more file changes (file content).  This can be extremely
     useful in situations where you don't want to distribute ssh keys,
     and use api tokens instead with CI systems.
@asedge asedge merged commit 665212e into NARKOZ:master Mar 28, 2017
@asedge
Copy link
Collaborator

asedge commented Mar 28, 2017

@logicminds Great, thanks!

andrew added a commit to librariesio/gitlab that referenced this pull request Apr 11, 2017
* upstream/master:
  release 4.0.0
  Move .file_contents to RepositoryFiles module, matching GitlabHQ API doc.  Also update route so it actually works with APIv4.
  Fix .get_file for new APIv4 route
  Update gitignore
  Add ability to get all issues a merge_request will close (NARKOZ#271)
  Update CHANGELOG, add some missing entries.
  Block/unblock user now uses POST instead of PUT.  Fixes NARKOZ#262.
  Adds ability to create commits (NARKOZ#264)
  Rename "git hook" to "push rule".  Closes NARKOZ#233.
  Change project fork endpoint for v4 API. Closes NARKOZ#236.
  Add v4-endpoint to fetch all merge_requests for a milestone (NARKOZ#265)
  Fixes NARKOZ#222, using deploy_keys endpoint (NARKOZ#261)
  (Un)subscribe to issues and merge_requests (NARKOZ#260)
  Update merge_request endpoints to new merge_requests endpoints (NARKOZ#256)
  Fix failing test that was called with a pre-urlencoded string.
  Allow issues to use NAMESPACE/REPO identifier (NARKOZ#255)
  Feature/230 note that project id can also be a string (NARKOZ#253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants