Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@formorer
Copy link

Hi,

this is a fix for #313 that allows adding ssh keys for other users.

@asedge
Copy link
Collaborator

asedge commented Sep 22, 2017

There are a couple problems here.

  1. You've added a function (username_search) that's unrelated to the topic of this PR. This is generally frowned upon, you really should file a separate PR for this function.
  2. There are no tests added for new code paths.

@formorer
Copy link
Author

I should look more often into my notifications, yes I am still interested we need that feature for Debians gitlab instance.

@NARKOZ
Copy link
Owner

NARKOZ commented Nov 29, 2017

@formorer please fix the issues that @asedge had mentioned. I'll merge after that.

Copy link
Owner

@NARKOZ NARKOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests and rebasing.

@NARKOZ
Copy link
Owner

NARKOZ commented Oct 4, 2018

#413

@NARKOZ NARKOZ closed this Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants