Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@asedge
Copy link
Collaborator

@asedge asedge commented Jun 8, 2018

…ntly undefined and when #method_missing is invoked, only expects 1 param, it is handed 2 parameters: [] and the key. This causes a confusing ArgumentError on #method_missing.

Fixes #359

…ntly undefined and when #method_missing is invoked, only expects 1 param, it is handed 2 parameters: [] and the key. This causes a confusing ArgumentError on #method_missing.
@asedge asedge requested a review from NARKOZ June 8, 2018 14:19
@NARKOZ
Copy link
Owner

NARKOZ commented Jun 16, 2018

Can you add tests, please? 🙏

…fy the set up for additional test cases so all that would be needed is a new response scenario and a new expected message.
@asedge
Copy link
Collaborator Author

asedge commented Jun 21, 2018

@NARKOZ I rewrote the tests so hopefully it's easier in the future to add new scenarios. Hopefully it's not too much. I'm interested in your feedback. Thanks!

Copy link
Owner

@NARKOZ NARKOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. LGTM.

@asedge asedge merged commit 2eb3a09 into master Jun 21, 2018
@NARKOZ NARKOZ deleted the do_not_access_objectified_hash_using_square_brackets branch August 7, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants