Removed unnecessary files from Gemspec to reduce file size of distributed gem #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uted gem Removed Specs + Docker configs + Dev configs Before: 1,4MB After: 380KB
Owner
|
LGTM 👍
No, we don't support Ruby 2.2 anymore as it reached EOL. https://www.ruby-lang.org/en/downloads/branches/ |
Owner
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: I want to use gitlab gem to run in a CLI and vendor all the dependencies. Gitlab was the largest with over 1MB. Granted, compared to node_modules the overhead is tiny, but nevertheless there are some needless configs that are shipped with the Gem but never needed for a usage.
Removed /specs + Docker configs + Dev configs
Size of the unzipped gem dir:
Before: 1,4MB
After: 380KB (-72%)
Instead of reject { .. regex } one could use grep_v, which is available from Ruby 2.3. I was not sure, if you are supporting Ruby 2.2 and lower though.