Allow to pass options for deploy keys #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NARKOZ
requested changes
Jul 29, 2018
| end | ||
|
|
||
| it "gets the correct resource" do | ||
| expect(a_post("/projects/42/deploy_keys"). |
Contributor
Author
There was a problem hiding this comment.
Oh indeed: will fix.
Contributor
Author
|
@NARKOZ Done. |
NARKOZ
reviewed
Jul 31, 2018
spec/gitlab/client/projects_spec.rb
Outdated
|
|
||
| it "gets the correct resource" do | ||
| expect(a_post("/projects/42/deploy_keys")). | ||
| with(body: { title: 'My Key', key: 'Key contents', can_push: true }).to have_been_made |
Owner
There was a problem hiding this comment.
Mismatched parentheses:
expect(a_post("/projects/42/deploy_keys").
with(body: { title: 'My Key', key: 'Key contents', can_push: true })).to have_been_made
Contributor
Author
There was a problem hiding this comment.
Very sorry...This time, I launched the specs locally.
NARKOZ
approved these changes
Jul 31, 2018
Owner
|
@born4new no problem. Thank you! 👍 |
Contributor
Author
|
@NARKOZ My pleasure. Would it be possible for you to create a gem release out of it? It's just so that people can just rely on the rubygems version of gitlab-ruby. |
Owner
|
@born4new version 4.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396