-
Notifications
You must be signed in to change notification settings - Fork 38
Zonal mean q oceans #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zonal mean q oceans #308
Conversation
|
#288 also includes some rof fixes that should be implemented when testing this... |
| " climo_nyears, int(base_end_date[:4]) - int(base_start_date[:4]) + 1\n", | ||
| " ),\n", | ||
| " }\n", | ||
| " case_dic[base_case_name] = {\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change was going to be addressed in #288 , but it probably makes more sense to have it here anyways, so I also added the parallel change to the other rof notebook.
|
Hi @nmizukami , I was able to get these two notebooks to run with """ I'm not sure why the non-serial method isn't working for me. Did you run this with dask successfully? |
Hi Teagan, I believe I was able to run with dask. I executed Yes, obs_available should be False. |
|
Hi @TeaganKing , I put a log from I am wondering about cupid-infrastructure. I have not update this env for long time. wondering if you have updated some packages? |
|
Ok, thanks Naoki. It seems like it is a sporadic error with dask-- eg, this case had a failure: but this one was fine: We should figure out what is causing the occasional dask errors, as they would seem concerning to users even if the plots are generated successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is unclear whether this error was introduced by this PR or previously present, and it doesn't create actual plot failures, I'm going to just merge this one in and add issue #311 to address the intermittent dask problem. The bug fixes in this PR should be prioritized.
Description of changes:
Adding plots of zonal mean annual flow to the oceans in global_discharge_ocean_compare_obs.ipynb
All PRs Checklist:
pre-commitchecks passed (#8 in Adding Notebooks Guide)?New notebook PR Additional Checklist (if these do not apply, feel free to remove this section):
parameters? These can cause confusing warnings that show up asDAG build with warnings./glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_dataand ensured that it follows this format within that directory:COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE?