Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nmizukami
Copy link
Member

@nmizukami nmizukami commented Oct 23, 2025

Description of changes:

  • Please add an explanation of what your changes do and why you'd like us to include them.

Adding plots of zonal mean annual flow to the oceans in global_discharge_ocean_compare_obs.ipynb

All PRs Checklist:

  • Have you followed the guidelines in our Contributor's Guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you made sure that the pre-commit checks passed (#8 in Adding Notebooks Guide)?
  • Have you successfully tested your changes locally when running standalone CUPiD?
  • Have you tested your changes as part of the CESM workflow?
  • Once you are ready to have your PR reviewed, have you changed it from a Draft PR to an Open PR?

New notebook PR Additional Checklist (if these do not apply, feel free to remove this section):

  • Have you hidden the code cells (#8 in Adding Notebooks Guide) in your notebook?
  • Have you removed any unused parameters from your cell tagged with parameters? These can cause confusing warnings that show up as DAG build with warnings.
  • Have you moved any observational data that you are using to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data and ensured that it follows this format within that directory: COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE?

@TeaganKing
Copy link
Collaborator

#288 also includes some rof fixes that should be implemented when testing this...

" climo_nyears, int(base_end_date[:4]) - int(base_start_date[:4]) + 1\n",
" ),\n",
" }\n",
" case_dic[base_case_name] = {\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change was going to be addressed in #288 , but it probably makes more sense to have it here anyways, so I also added the parallel change to the other rof notebook.

@TeaganKing
Copy link
Collaborator

TeaganKing commented Oct 27, 2025

Hi @nmizukami , I was able to get these two notebooks to run with cupid-diagnostics -rof --serial with also adding two lines to the ROF additional setup cell (cell 5):

"""
case_dic = {
case_name: {
"grid": grid_name,
"sim_period": slice(f"{start_date}", f"{end_date}"),
"climo_nyrs": min(climo_nyears, int(end_date[:4]) - int(start_date[:4]) + 1),
"output_dir": CESM_output_dir,
}
}
if base_case_name is not None:
case_dic[base_case_name] = {
"grid": grid_name,
"sim_period": slice(f"{base_start_date}", f"{base_end_date}"),
"climo_nyrs": min(
climo_nyears, int(base_end_date[:4]) - int(base_start_date[:4]) + 1
),
"output_dir": base_case_output_dir
}
"""
It looks like obs_available must have gotten set to false, though, since no obs plots showed up.

I'm not sure why the non-serial method isn't working for me. Did you run this with dask successfully?

@nmizukami
Copy link
Member Author

Hi @nmizukami , I was able to get these two notebooks to run with cupid-diagnostics -rof --serial with also adding two lines to the ROF additional setup cell (cell 5):

""" case_dic = { case_name: { "grid": grid_name, "sim_period": slice(f"{start_date}", f"{end_date}"), "climo_nyrs": min(climo_nyears, int(end_date[:4]) - int(start_date[:4]) + 1), "output_dir": CESM_output_dir, } } if base_case_name is not None: case_dic[base_case_name] = { "grid": grid_name, "sim_period": slice(f"{base_start_date}", f"{base_end_date}"), "climo_nyrs": min( climo_nyears, int(base_end_date[:4]) - int(base_start_date[:4]) + 1 ), "output_dir": base_case_output_dir } """ It looks like obs_available must have gotten set to false, though, since no obs plots showed up.

I'm not sure why the non-serial method isn't working for me. Did you run this with dask successfully?

Hi Teagan, I believe I was able to run with dask. I executed cupid-diagnostics -rof . But, I did see a bunch of message from a dask, which I thought could be ignored. I can re-run and post what that says.

Yes, obs_available should be False.

@nmizukami
Copy link
Member Author

Hi @TeaganKing , I put a log from cupid-diagnostics -rof here.
/glade/work/mizukami/CUPiD/examples/key_metrics/cupid-diagnostics-rof.log.local.

I am wondering about cupid-infrastructure. I have not update this env for long time. wondering if you have updated some packages?

@TeaganKing TeaganKing added the bug Something isn't working label Oct 27, 2025
@TeaganKing
Copy link
Collaborator

Ok, thanks Naoki. It seems like it is a sporadic error with dask-- eg, this case had a failure:
/glade/work/tking/cupid_project/other_cupids/234v238/CUPiD/examples/key_metrics/

but this one was fine:
/glade/work/tking/cupid_project/other_cupids/234v236.002/CUPiD/examples/key_metrics

We should figure out what is causing the occasional dask errors, as they would seem concerning to users even if the plots are generated successfully.

Copy link
Collaborator

@TeaganKing TeaganKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is unclear whether this error was introduced by this PR or previously present, and it doesn't create actual plot failures, I'm going to just merge this one in and add issue #311 to address the intermittent dask problem. The bug fixes in this PR should be prioritized.

@TeaganKing TeaganKing merged commit 42f4265 into NCAR:main Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lnd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants