bug-fix: Obs_seq_to_netcdf appending files #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added logic to obs_seq_to_netcdf to keep track of whether a files has been created for an epoch during that run of obs_seq_to_netcdf. Previously if there were multiple obs_sequence files in an epoch, the epoch file was being created afresh for each obs_seq file. Thus, only obs from the last file in the list were present in obs_epoch.nc
Fixes issue
#12
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Epochs set for 1 day long for the month of February:
List of obs_sequence files with multiple obs sequences in epoch Feb 5th.
check number of obs in epoch files match sum from obs_seq files.
obs_epoch_005.nc
obs_epoch_013.nc
obs_epoch_029,nc
Checklist for merging
Testing Datasets