Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mjs2369
Copy link
Contributor

@mjs2369 mjs2369 commented May 31, 2022

Description:

Fixes the issues occurring in ps_rand_local.f90 - missing call for initialize_utilities() and improper formatting when writing into ps_rand.out

Fixes issue

Fixes #354

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Compiled and ran ./ps_rand_local < ps_rand.input followed by ./create_obs_sequence < ps_rand.out. Tested a number of different values for the variables in ps_rand.input to ensure the output in ps_rand.out maintained the correct formatting and create_obs_sequence was able to execute. Used both gfortran and Intel to compile and test.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Version tag

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@mjs2369 mjs2369 requested a review from hkershaw-brown May 31, 2022 15:52
Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@mjs2369 mjs2369 merged commit 52816c2 into main Jun 2, 2022
@mjs2369 mjs2369 deleted the bug-fix-ps-rand-local branch June 2, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems with ps_rand_local in the Bgrid Model

3 participants