Changes to WOD fortran files to be compatible with WOD23 ascii files #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this Kate! It might be a little while before we get to this because we have a few pull requests in the queue, but thanks for the bug report and the fix. |
Comment on lines
+93
to
+95
| "$URL: https://svn-dares-dart.cgd.ucar.edu/DART/releases/Manhattan/observations/obs_converters/WOD/wod_to_obs.f90 $" | ||
| character(len=32 ), parameter :: revision = "$Revision: 11243 $" | ||
| character(len=128), parameter :: revdate = "$Date: 2017-03-08 14:35:09 -0700 (Wed, 08 Mar 2017) $" |
There was a problem hiding this comment.
@hkershaw-brown svn info, can remove this
|
Thanks for this Kate, as I mentioned in slack I'm just putting a bunch of notes on this (because it is old code) None of the notes are on your changes (so sorry for the noise), apart from Cheers, |
Closed
hkershaw-brown
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes to two fortran files in order for the WOD23 and WOD18 ascii files to be correctly read in
Fixes issue
fixes #939
Types of changes
The changes were made by copying Fred Castruccio's WOD fortran files 1) wod_read_routines.f90 and 2) wod_to_obs.f90. The original files can be found on derecho at /glade/u/home/fredc/DART/Manhattan/observations/obs_converters/WOD
Tests
I have yearly WOD obs sequence output files for 2012-2017 that have reasonable values by inspection.
Checklist for merging
Checklist for release
Testing Datasets