Apply cap on WRF-DART resubmits #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkershaw-brown
requested changes
Aug 5, 2025
There was a problem hiding this comment.
Hi Brett,
This caps the number of resubmissions to fix #923
I've left one suggestion on changing a confusing comment, and one definite change.
The definite change is to have driver.csh exit with an error code if a wrf member fails.
As Moha brought up at standup there are several ways to modernize/improve the workflow, but these are out of scope for this fix.
Cheers,
Helen
Co-authored-by: Helen Kershaw <[email protected]>
Co-authored-by: Helen Kershaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Applies 2 resubmit cap for WRF ensemble members submissions during assim_advance step within driver.csh.
This prevents rare cases of 'zombie' jobs that need to be killed based on PID.
Fixes issue
Fixes #923
Types of changes
Documentation changes needed?
The change outputs a clear error message and provides instructions on how to diagnose the problem.
Tests
Ran WRF-DART tutorial and forced WRF failure to test fix.
See /glade/derecho/scratch/bmraczka/WRFv4.5_maxretry
Checklist for release
Testing Datasets