ROMS-Rutgers Interface #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original ROMS code has been renamed to ROMS_ucla reflecting the version of the ROMS model. This prepares for adding the new ROMS_rutgers code.
Completed developing the model_mod.f90 Added several obs_seq files for testing purposes Edited some of the ROMS_ucla documentation
Added readme file with detailed documentation
Added a figure and an illustrative example in the readme file
hkershaw-brown
requested changes
Aug 5, 2025
There was a problem hiding this comment.
HI Moha,
I left a bunch of comments. Most are code you can remove for various reasons (default model_mod function available, routines from UCLA only)
Nice docs, I'd like to pull out the routine documentation though - see comment.
There is a question on the interpolation, mostly for my understanding.
There are some comments on memory usage, which don't have to be addressed now but may need to be if memory becomes a problem.
I think the init_quad_interp will have to deal with spans lons and pole cases for various different ROMS regions.
Cheers,
Helen
There was a problem hiding this comment.
@hkershaw-brown @mjs2369
Release notes should inform users of ROMS -> ROMS_ucla rename as they may need to update any workflows.
Removed the description of the key model-mod routines
- Improved comments - i8 for model size - Got rid of local parsing routines. Used default ones instead
- Improved comments - Additional land checks when generating an ensemble - Got rid of old functionality that allowed ROMS time advances - Reverted to using the default get_close_obs from the location-mod - Generalized the quad initialization to support more geographic domains
Removed older routines from the ucla version to read in time and added new more concise ones
- Got rid of the large 3D arrays: TDEP, UDEP, VDEP. The physical depth is now computed on the fly. This frees up a lot of memory and makes filter more efficient. - Added an interface to compute depth for scalar (in get_state_meta_data) and array (in model_interpolate) depths. - Sea surface height is used while computing depth for model_interpolate only (not the case for gsmd) - Adjusted vertical interpolation routine to allow for qty reading. - Imrproved comments and cleaned code - Removed unneeded dry land checks when perturbing the ensemble
hkershaw-brown
approved these changes
Aug 19, 2025
bae55cb to
b504aca
Compare
hkershaw-brown
added a commit
that referenced
this pull request
Aug 26, 2025
hkershaw-brown
added a commit
that referenced
this pull request
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
An interface to the ROMS Rutgers version has been developed. The new interface is different than the current ROMS interface which was specifically designed for the UCLA version of the model (uses precomputed forward operators). The new interface is called ROMS_rutgers while the old on has been renamed to ROMS_ucla.
Fixes issue
This addresses issue #898
Types of changes
Documentation changes needed?
Tests
I've tested the new interface using model-mod-check and filter. For filter, I run many experiments each assimilating different observation sequences. All tested obs_seq files can be found in
ROMS_rutgers/obs_seqs. I also tested the new interface with and without adaptive inflation.Testing Datasets
I have run all my experiments here:
/glade/derecho/scratch/gharamti/inacawo/DART/models/ROMS_rutgers/workusing thejob.shscript within the work directory. The template ROMS history file is titledroms_hist_z.nc.