Feature 55: Use dataTableAjax in and add obs_count to Party table #104
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements server-side search and paging for the party table using the dataTablesAjax approach, adds an obs_count column, and removes the cached party data file along with its associated loading logic. This aligns the party table implementation with the approach already used for concept tables.
- Removes server-side caching and replaces it with on-demand AJAX fetching
- Adds observation count column to party table display
- Introduces helper functions for data normalization and schema enforcement
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/testthat/test_party_table.R | Updates tests to verify remote table configuration and new processing functions |
| inst/cached_data/py_20251014.rds | Removes cached party data file |
| R/table_party.R | Implements remote table configuration with AJAX, adds obs_count column, and creates normalization helpers |
| R/server.R | Removes cached party data loading and updates build_party_table call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
regetz
left a comment
There was a problem hiding this comment.
Nice! Super excited to see more tables fully working against the API, without requiring cached local data.
What:
Closes #55 by implementing dataTablesAjax server-side search and paging functionality and adding a obs_count column to the party table.
Why:
To further minimize the data stored in the shiny server session and align with the approach taken for concept tables.
How:
Docs and Testing: