Fix hydration race by disabling nav bar during load #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents a hydration race condition that could occur when users interact with the navigation bar during initial app state restoration from URL parameters. The fix disables navigation interactions until the app's history state is fully initialized.
Key changes:
- Added JavaScript functions and CSS rules to disable/enable navbar interaction
- Modified server-side logic to coordinate navbar state with URL history initialization
- Enhanced history readiness checks throughout URL state synchronization code
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| R/ui.R | Added JavaScript setNavbarDisabled function, custom message handler, and CSS rules to control navbar interactivity during initialization |
| R/server.R | Added onFlushed callback to initially disable navbar; enhanced history initialization tracking; updated observers to respect history readiness before URL updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Prevent's the possibility of a url hydration race while the app loads by disabling keyboard focus and mouse interaction with the navbar during state restoration from the url.
Why: As described in #92, clicking a navbar during state restoration led to a hydration race.
How:
Testing: