Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Sep 5, 2025

Description

Add support for fields with data_dims (or data_dims only fields) in the stencil wrapper's function to compute field origins.

This PR is work that's being propagated back from the nasa/milestone2 branch.

How Has This Been Tested?

Added new unit test. Tested locally with bigger reproducer (GFDL_1M orchestration).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

Add support for fields with data_dims (or data_dims only fields) in the
stencil wrapper's function to computae field origins.
Copy link
Collaborator

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clean, thanks

@romanc romanc added this pull request to the merge queue Sep 5, 2025
Merged via the queue into NOAA-GFDL:develop with commit 37170dc Sep 5, 2025
5 checks passed
@romanc romanc deleted the romanc/fix-stencil-wrapper-data_dims-origins branch September 12, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants