Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@romanc
Copy link
Collaborator

@romanc romanc commented Oct 6, 2025

Description

While these functions had internal usage, they are trivally replacable by either os.path methods or pathlib calls. We envision the future of NDSL to work with pathlib as interface to the filesystem.

This PR is to be seen in preparation for and context of issue #243, which proposes a bigger cleanup in the directory structure of this package. If we can get rid of some deprecated API first, transition will be easier.

How has this been tested?

Added new tests to ensure that a deprecation warning is shown for the deprecated functions.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
    No, but that's kind of the point of adding deprecation warnings ;)
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included

While these functions had internal usage, they are trivally replacable
by either `os.path` methods or `pathlib` calls. We envision the future
of NDSL to work with `pathlib` as interface to the filesystem.
@romanc romanc changed the title api cleanup: remove ndsl/filesystem.py api cleanup: deprecate ndsl/filesystem.py Oct 6, 2025
@romanc romanc changed the title api cleanup: deprecate ndsl/filesystem.py API cleanup: deprecate ndsl/filesystem.py Oct 6, 2025
@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Oct 6, 2025
Merged via the queue into NOAA-GFDL:develop with commit a8b44ff Oct 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants