[API Update] NDSLRuntime uses the wider StencilFactory rather than a narrow config#335
Merged
FlorianDeconinck merged 4 commits intoNOAA-GFDL:developfrom Nov 28, 2025
Conversation
twicki
approved these changes
Nov 28, 2025
Collaborator
twicki
left a comment
There was a problem hiding this comment.
Looks good, ready to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We fix here a misguided choice of original API before the class becomes wide spread.
Previous API of
NDSLRuntimetook the only required argument, e.g.DaCeConfig. This is quite narrow and will lead any extension of the system to lack data and have an API update. On top of it, the dace config is burried, in most cases, within the stencil factory, which is not user friendly.We prefer here to pass down the full
StencilFactory, which is a common factory to carry around model code, and extract what we need for it.StencilFactorycarries configs and grid indexing, which should cover most basic information.How has this been tested?
Update to the utest
Checklist