Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[API Update] NDSLRuntime uses the wider StencilFactory rather than a narrow config#335

Merged
FlorianDeconinck merged 4 commits intoNOAA-GFDL:developfrom
FlorianDeconinck:feature/update_ndslruntime_api
Nov 28, 2025
Merged

[API Update] NDSLRuntime uses the wider StencilFactory rather than a narrow config#335
FlorianDeconinck merged 4 commits intoNOAA-GFDL:developfrom
FlorianDeconinck:feature/update_ndslruntime_api

Conversation

@FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented Nov 27, 2025

Description

We fix here a misguided choice of original API before the class becomes wide spread.

Previous API of NDSLRuntime took the only required argument, e.g. DaCeConfig. This is quite narrow and will lead any extension of the system to lack data and have an API update. On top of it, the dace config is burried, in most cases, within the stencil factory, which is not user friendly.

We prefer here to pass down the full StencilFactory, which is a common factory to carry around model code, and extract what we need for it. StencilFactory carries configs and grid indexing, which should cover most basic information.

How has this been tested?

Update to the utest

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Collaborator

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready to go!

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Nov 28, 2025
Merged via the queue into NOAA-GFDL:develop with commit fb53d16 Nov 28, 2025
6 checks passed
@FlorianDeconinck FlorianDeconinck deleted the feature/update_ndslruntime_api branch November 28, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants