Parameterize SubtileGridSizer to allow variation of the padding on non-interface field#347
Merged
FlorianDeconinck merged 9 commits intoNOAA-GFDL:developfrom Jan 8, 2026
Conversation
…on non-interface field. This will lead to an API break down the road, as we know require the backend to be given.
Collaborator
Author
|
@oelbert for visibility. In Pace after the January release, you will be required to give |
fmalatino
approved these changes
Dec 29, 2025
romanc
previously requested changes
Jan 7, 2026
Collaborator
romanc
left a comment
There was a problem hiding this comment.
If we can avoid it, I wouldn't change the GridSizer base class (see inline).
twicki
reviewed
Jan 8, 2026
Collaborator
There was a problem hiding this comment.
just generally if we're already touching this: Is there a case where we want to turn on or off (ij) and k padding independently - physics vs dynamics? Or do we acutally think padding shoud in the long term go completely and not worry about it?
Collaborator
Author
There was a problem hiding this comment.
If we need to do padding for cache line prefetch, we can do it via the strides rather than element count. So I'd vote no, it should just go away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧱🧱 BLOCKED BEHIND GridTools/gt4py#2426 🧱🧱
Description
In order to allow zero-copy memory mapping from Fortran (case of GEOS) we need to parameterize
GridSizerand children to allow variation of the padding on non-interface field. This PR takes care of it by requiring the backend and checking it's Fortran friendliness. Further discussion should question the need for padding altogether.This will lead to an API break down the road, as we know require the backend to be given to the
SubtileGridSizer.Also:
How has this been tested?
New unit test.
Checklist