[Feature | Experimental] SDFG code labeler#359
Merged
FlorianDeconinck merged 7 commits intoNOAA-GFDL:developfrom Jan 12, 2026
Merged
[Feature | Experimental] SDFG code labeler#359FlorianDeconinck merged 7 commits intoNOAA-GFDL:developfrom
FlorianDeconinck merged 7 commits intoNOAA-GFDL:developfrom
Conversation
Hook on _INTERNAL__SCHEDULE_TREE_OPTIMIZATION for safety
romanc
approved these changes
Jan 9, 2026
Collaborator
romanc
left a comment
There was a problem hiding this comment.
This looks good to me. I'd just ask to change Labeller to Labeler (single l) to be consistent with US-English that we generally use in the package (e.g. we'd write color and behavior). More on labeller vs labeler.
romanc
requested changes
Jan 9, 2026
Collaborator
romanc
left a comment
There was a problem hiding this comment.
Can you rename the labeller -> labeler? (Like filename and classname and in the title of the PR)
Collaborator
Author
Oooh good catch |
romanc
reviewed
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The first step to allow performance developer to deploy custom made optimization pipeline in orchestration, we need to be able to label the code so we can capture the correct tree or SDFG for optimization.
This PR introduces a function that surround the SDFG with two state/library node combo labelling. Because of the passthrough nature, the library node will be removed by simplify, which is a good side effect.
Testing has been done locally and for safety the feature is hooked on the
_INTERNAL__SCHEDULE_TREE_OPTIMIZATIONexperimental flag for schedule tree optimization.Unit test for this particular feature are difficult because of the non-modular structure of orchestration. We expect test to come for the full "custom optimization pipeline" that will leverage this.
Checklist