Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented Jun 13, 2024

Description
Part of the mixed precision small details left after the original push. "Parameters" in translate test are not casted to Float using the global precision mechanism, leading to numerical errors for translate check at 32-bit float.

How Has This Been Tested?
Ongoing port of the microphysics in GEOS

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FlorianDeconinck FlorianDeconinck merged commit 6580f0f into develop Jun 13, 2024
@FlorianDeconinck FlorianDeconinck deleted the fix/missing_Float_cast_translate_parameters branch June 13, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants