Thanks to visit codestin.com
Credit goes to github.com

Skip to content

support -moz-document rule #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2012
Merged

support -moz-document rule #47

merged 2 commits into from
Dec 20, 2012

Conversation

@webup
Copy link

@webup webup commented Dec 17, 2012

Please review it! Thanks!

@NV
Copy link
Owner

NV commented Dec 17, 2012

Could you add a spec? At least one to parse.spec.js is a must. Testing every introduced method is nice but not a requirement.

@webup
Copy link
Author

webup commented Dec 18, 2012

@NV
Note that:

  • MatcherList.js is basically a copy of MediaList.js. The reason why I create it is that I think the match function maybe different from media, a url can include some special character such as ',' and '{'. Well actually the current solution will lead to an error when a url has a ',' or '{' in it. I'm thinking how to fix this. Any idea?

NV added a commit that referenced this pull request Dec 20, 2012
@NV
Merge pull request #47 from webup/gh-pages
9446e7a 
support -moz-document rule
@NV NV merged commit 9446e7a into NV:gh-pages Dec 20, 2012
@NV
Copy link
Owner

NV commented Dec 20, 2012

I don’t yet know how to fix it

@snyk-bot snyk-bot mentioned this pull request Apr 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@webup @NV @wuchengwei